RSS

Working on Mozilla Bug 601535 [0.3 Release]

23 Feb

So I had somehow disappeared from the blogging space for a while now. More likely, I didn’t disappear, but the Pointer Lock API test took so much of my time that I literally stopped on my other courses. Hence I took some time off from open source to bring my other course up to speed.

For reader that is not in my open source class and is wondering what 0.3 Release means, you can ignore them. It is used so that my professor can track my progress and grade me. :)

For this blog, I will be discussing my troubles with Bug 601535, which I mentioned a little bit in one of my earlier blog.

Background on the Bug

The bug involves changing all instance of MulOverflow and AddOverflow in the content/media folders. In place, I am supposed to use the CheckedInt utility class. This class checks whether the number is valid or not, that is to say, it is this super awesome cyborg that takes in number and tells me if the number is too big or not. ;)

I was a little big lucky off with working on this bug because it was partially worked on by someone else. There is a both pros and cons with regard to having a bug partially worked on. The pro is that I get a decent amount of examples to look through and someone already reviewed the older patch and I get the feedback right away. The cons are I need to understand the bug first, what files it affects and what the earlier person did.

Working on the Bug

Okay, I know, the sub-heading is the exact as the blog heading. (It’s been a long week, don’t ask).

This bug was worked on by someone two years ago, and two years in computer code is ten lifetime and the current code is in the tenth generation. This translates to numerous differences in code. As such, my job involved (after I understood the bug properly):

  • Get the old patch and put it in my code.
  • Put in the suggestions put up by the reviewer.

This may sound simple, but it is not.

Adding the Patch

After I was satisfied with the bug, I began preparing a diff to be uploaded and this took me two days. TWO DAYS TO GET A DIFF!!!! Somehow github was giving me a lot of trouble when trying to rebase. I am going to sit with Jon Buckley, who is pretty good at github and shall see what went wrong.

In short, the code is landed and the diff issue I had to re-do from a different branch. I will soon post a blog once I figured out what went wrong and maybe help someone (me) in need.

 
Leave a comment

Posted by on February 23, 2012 in Firefox, Mozilla, Open Source

 

Tags: , , , ,

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Connecting to %s

 
Follow

Get every new post delivered to your Inbox.